[llvm-commits] [llvm] r166685 - in /llvm/trunk: docs/HowToUseInstrMappings.rst docs/WritingAnLLVMBackend.html include/llvm/Target/Target.td utils/TableGen/CodeGenMapTable.cpp utils/TableGen/InstrInfoEmitter.cpp utils/TableGen/TableGenBackends.h

[David Blaikie]

On Thu, Oct 25, 2012 at 10:24 AM, Sebastian Pop <spop at codeaurora.org> wrote:
> On Thu, Oct 25, 2012 at 12:06 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> If possible, running your local builds with clang & using -Werror
>> (both the configure+make and cmake builds have options to enable
>> -Werror) is a great way to avoid these breaks. We all try pretty hard
>> to keep the clang build clean.
>
> Sorry for the disruption my commit has caused, I will test the patches with
> clang and -Werror from now on.
>
> Just out of curiosity, isn't -Werror in the default flags for building LLVM when
> not configured in release mode?

Nope, it's an extra option in either build system. Perhaps we should
make it the default when the build system has detected it is building
with clang (we already do that detection to turn on certain warning
flags). Though this could cause a few hiccups for people using older
versions of Clang that might have spurious warnings.

(we certainly aren't GCC warning clean so it wouldn't be good to
-Werror when building with GCC)