[llvm-commits] [cfe-commits] Reduce exception handling use in TableGen

[Jakob Stoklund Olesen]

On Oct 23, 2012, at 9:07 AM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:

> On Mon, Oct 22, 2012 at 10:26:48AM -0700, Jakob Stoklund Olesen wrote:
>> The location-less errors are really annoying, please try to find a way
>> of preserving the location info. It also looks like many of the throws
>> you converted (outside SetTheory) could easily pass a relevant location
>> to PrintFatalError.
> 
> Sure, can work on providing that, but it changes the interface.

Thanks.

The SetTheory classes don't have any other clients than what you see, so changing the interface is fine.

>> Is it possible to get rid of the TGError exception class as well?
> 
> I think so. Without throwing exceptions around, it is just a fancy way
> to store message and location.

Thanks,
/jakob