[llvm-commits] Patch to add address space support to getIntPtrTy

[Villmow, Micah]

Yeah, I have some tests(mostly modified copies of the tests already in llvm), but I need to make more changes before they all pass, so I'll be checking them in with the relevant changes that let them pass.

> -----Original Message-----
> From: Eli Friedman [mailto:eli.friedman at gmail.com]
> Sent: Tuesday, October 23, 2012 4:01 PM
> To: Villmow, Micah
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Patch to add address space support to
> getIntPtrTy
> 
> On Tue, Oct 23, 2012 at 3:55 PM, Villmow, Micah <Micah.Villmow at amd.com>
> wrote:
> >> Sorry to bug you again about this, but can you give a specific
> >> example in the patch where the "Otherwise" case is useful?
> > [Villmow, Micah] Added:
> > "An example of this occuring is that you want to get the IntPtrTy for
> > all of the arguments in a function. However, the IntPtr for a
> > non-pointer type cannot be determined by the type itself, so the
> default pointer is used instead."
> >
> > [Villmow, Micah] I've made the rest of the corrections, so looking to
> check in once I get approval for this.
> 
> I don't have any further review comments.  As long as you think you have
> a reasonable testing story, feel free to commit.
> 
> -Eli