[llvm-commits] LLD Add x86 relocation reference code

Eric Christopher echristo at gmail.com
Mon Oct 22 15:52:44 PDT 2012


+/// Symbols used:
+///  A: Added used to compute the value, r_addend
+///  P: Place, address of the field being relocated, r_offset
+///  S: Value of the symbol whose index resides in the relocation entry.

Couple comments:

a) A: "Addend" used
b) Might want to reorder the comments to match the ordering of
arguments in the function. Could keep that ordering even when you add
G, GOT, etc.

-eric

On Fri, Oct 19, 2012 at 3:15 PM, Sid Manning <sidneym at codeaurora.org> wrote:
>
> This attached change does the following:
>   * Moves x86 content from ReferenceKinds.cpp to a new file,
> x86Reference.cpp
>   * Adds support for R_386_32 and R_386_PC32 relocs
>   * Includes simple testcase
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list