[llvm-commits] [llvm] r166224 - in /llvm/trunk: docs/TestingGuide.html utils/lit/lit/ExampleTests/xfail-feature.c utils/lit/lit/TestRunner.py

[Chandler Carruth]

On Fri, Oct 19, 2012 at 10:24 AM, Daniel Dunbar <daniel at zuster.org> wrote:

> On Fri, Oct 19, 2012 at 1:11 AM, Chandler Carruth <chandlerc at google.com>
> wrote:
> > On Thu, Oct 18, 2012 at 1:43 PM, Daniel Dunbar <daniel at zuster.org>
> wrote:
> >>
> >> Author: ddunbar
> >> Date: Thu Oct 18 15:43:04 2012
> >> New Revision: 166224
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=166224&view=rev
> >> Log:
> >> lit: Allow XFAIL: lines to also refer to "features".
> >
> >
> > What's the motivation for this patch?
>
> The specific use case was wanting to XFAIL something that is broken
> when the compiler is built with LTO, but the reason I went this route
> was it seemed like a reasonably sensical and orthogonal feature.
>
> > I would much rather continue to use directory structures and/or REQUIRES
> to
> > represent feature differences.
>
> That is a different use case, that indicates the test needs a
> particular feature, this indicates a test fails with a particular
> feature.
>
> From a design standpoint, it actually seems cleaner to have all of the
> REQUIRES, XFAIL, XTARGET lines draw from the same namespace, and maybe
> move to treating triples as just another "feature". This is just a
> step closer to that.


Ok, this makes more sense then. Thanks for the explanation.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121019/cb15ba30/attachment.html>