[llvm-commits] [ARM] Extra frame for non-VA byval parameter

[Stepan Dyatkovskiy]

We invoke VarArgsStyleRegisters for the first byval argument only. If I 
got right its memory part starts with ArgOffset = 0 always. I inserted 
assertion "VA.getLocMemOffset() == 0" at the beginning of this branch 
just for belaying.
Though is there any hypotetical cases where it may fail?

-Stepan.
>
> For the patch, should we pass VA.getLocMemOffset() as ArgOffset to VarArgStyleRegisters?
>
> -            int FI = MFI->CreateFixedObject(Bytes,
> -                                            VA.getLocMemOffset(), false);
> +              VarArgStyleRegisters(CCInfo, DAG,
> +                                   dl, Chain, CurOrigArg,
> +                                   Ins[VA.getValNo()].PartOffset, 0);
>
> Otherwise LGTM,