[llvm-commits] [PATCH 7/10] Initial TOC support for PowerPC64 object creation

[Adhemerval Zanella]

Hi Rafael,

I found out why it failed on non-ppc64 environments: PPCSubtarget class isn't setting
64-bit support for 'generic' cpus types (the default 'cpu' for where neither -mcpu=xxx
or host can't be detected). I fixed this and tested on a x86_64 target.

I also cleanup the unused arguments you pointed on IRC. I planned to commit your proposed
patch, but I believe now this one is good. Any objections?


On 10/11/2012 05:19 PM, Adhemerval Zanella wrote:
> On 10/11/2012 04:02 PM, Rafael Espíndola wrote:
>>> Hi Rafael,
>>>
>>> I added your recommendations and changed the 'checkRelocationUndefined' with a
>>> new hook. Is is ok now?
>> I provided some feedback on IRC, but I also noticed that the patch can
>> be split. For example, would you mind committing just the attached
>> patch first? It just adds EmitTCEntry, which is a good, independent,
>> improvement.
>>
>> Cheers,
>> Rafael
> Ok, I'll. I found out why the testcase failed in your environment: for some reason
> the featureBits in the MCSubtargetInfo class creation does not use the mtriple argument,
> relying only on the mcpu string or host info to set the target bits. I'm still investigating why, but if you
> add -mcpu=ppc64 the testcase passes on a i386 build.
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Initial-TOC-support-for-PowerPC64-object-creation.patch
Type: text/x-patch
Size: 23912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121015/6989b212/attachment.bin>