[llvm-commits] [PATCH, test-suite, AltiVec][2/4] Fix pre-ANSI C

Hal Finkel hfinkel at anl.gov
Fri Oct 12 08:43:16 PDT 2012


----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: llvm-commits at cs.uiuc.edu
> Sent: Friday, October 12, 2012 10:30:32 AM
> Subject: Re: [llvm-commits] [PATCH, test-suite, AltiVec][2/4] Fix pre-ANSI C
> 
> Hal Finkel <hfinkel at anl.gov> wrote on 12.10.2012 15:31:40:
> 
> > I think this is fine.
> 
> Thanks for the review; I've now checked all four patches in.
> 
> > Out of curiosity, do all relevant compilers
> > (that understand AliVec) also understand __complex__, or should we
> > change to the C99 _Complex keyword)?
> 
> There's at least one other test that uses __complex__
> (SingleSource/Benchmarks/Misc/mandel.c), so I'd expect
> this to be supported by all relevant compilers ...
> 
> But I guess we could as well change to _Complex -- would
> you like me to prepare a patch to do so?

Yes, please.

Thanks again,
Hal

> 
> Bye,
> Ulrich
> 
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list