[llvm-commits] First patch to add support for variable address spaces to optimizers

[Villmow, Micah]

Ok, had a few minutes to get this patch together. I've made the changes to the ConstantExpr and looked through the code to see if I made any other obvious wrong changes.

Thanks for the reviews,
Micah
________________________________________
From: Chris Lattner [clattner at apple.com]
Sent: Thursday, October 11, 2012 5:13 PM
To: Villmow, Micah
Cc: Eli Friedman; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] First patch to add support for variable address spaces to optimizers

On Oct 11, 2012, at 2:31 PM, "Villmow, Micah" <Micah.Villmow at amd.com> wrote:

> I didn't think I broke the C API, this patch does add new interfaces, is there something I'm missing?
> Please let me know what else I need to correct with this patch, I'll re-investigate the CE to Inst cast issue, I thought I had fixed all of them, but looks like I missed some.

Ok, checking again, I see you fixed the C API issue, thanks.  If you can get the ExecutionEngine bugs fixed by today, I don't have a problem keeping it in mainline.  Thanks Micah,

-Chris

> Thanks,
> Micah
>
>> -----Original Message-----
>> From: Chris Lattner [mailto:clattner at apple.com]
>> Sent: Thursday, October 11, 2012 2:22 PM
>> To: Villmow, Micah
>> Cc: Eli Friedman; llvm-commits at cs.uiuc.edu
>> Subject: Re: [llvm-commits] First patch to add support for variable
>> address spaces to optimizers
>>
>>
>> On Oct 11, 2012, at 11:22 AM, "Villmow, Micah" <Micah.Villmow at amd.com>
>> wrote:
>>
>>> R165726.
>>
>> Please revert this patch.  There are serious problems with it, both in
>> correctness, and in design.  You can't break the C API.
>>
>> -Chris
>>
>>>
>>>> -----Original Message-----
>>>> From: Eli Friedman [mailto:eli.friedman at gmail.com]
>>>> Sent: Wednesday, October 10, 2012 4:25 PM
>>>> To: Villmow, Micah
>>>> Cc: llvm-commits at cs.uiuc.edu
>>>> Subject: Re: [llvm-commits] First patch to add support for variable
>>>> address spaces to optimizers
>>>>
>>>> On Wed, Oct 10, 2012 at 4:00 PM, Villmow, Micah
>> <Micah.Villmow at amd.com>
>>>> wrote:
>>>>> Yeah, not sure which ones I need to modify though, then ones where
>> I
>>>> default to 0 I don't really see how I can get the address space, so
>> I
>>>> set it to the default.
>>>>
>>>> I was thinking for the places where we're looking for the size of
>> e.g.
>>>> a pointer to a label (like in MachineFunction.cpp), you could add a
>>>> special method "get the pointer size for the address space for the
>>>> generated code is in".  Actually, I just realized that probably
>>>> shouldn't be a global target setting anyway, and it isn't important
>>>> for the first iteration, so ignore me. :)
>>>>
>>>> (The patch looks fine otherwise.)
>>>>
>>>> -Eli
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 001-patch-to-support-per-pointer-address-space.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121011/a2705f5d/attachment.txt>