[llvm-commits] [PATCH 7/10] Initial TOC support for PowerPC64 object creation

[Adhemerval Zanella]

On 10/05/2012 11:47 AM, Adhemerval Zanella wrote:
>
>>
>> I think the main question is why are you using ExplicitRelSym?
>> Wouldn't it be better to add a new hook with a default implementation
>> that returns &ASymbol? That way you can avoid all the
>> checkRelocationUndefined plumbing.
> I was in doubt which would be the best approach. I decided to use this one
> to in fact avoid another hook, but if you think it is better I can modify
> the patch to use it.
>
> Thanks for the review.

Hi Rafael,

I added your recommendations and changed the 'checkRelocationUndefined' with a
new hook. Is is ok now?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Initial-TOC-support-for-PowerPC64-object-creation.patch
Type: text/x-patch
Size: 23422 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121010/97c7fb02/attachment.bin>