[llvm-commits] [PATCH, PowerPC] Fix test case for default unsigned char platforms

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Wed Oct 10 10:39:14 PDT 2012


Hello,

the SingleSource/UnitTests/2003-07-09-SignedArgs.c test case
fails on PowerPC because it wants to verify that "char" arguments
are sign-extended.  However, whether a plain "char" is signed or
unsigned in C is implementation-defined, and on PowerPC plain
char happens to be unsigned.

The appended patch fixes the test by simply making the assumption
explicit and using "signed char" instead of "char" throughout.

OK to commit?

Bye,
Ulrich
(See attached file: diff-testsuite-signedchar)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-testsuite-signedchar
Type: application/octet-stream
Size: 1782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121010/8b2a7bd1/attachment.obj>


More information about the llvm-commits mailing list