[llvm-commits] LDRB_POST_IMM crash

[Silviu Baranga]

LGTM

-- Silviu

> -----Original Message-----
> From: Stepan Dyatkovskiy [mailto:stpworld at narod.ru]
> Sent: 10 October 2012 10:08
> To: llvm-commits; Silviu Baranga
> Subject: Fwd: Re: [llvm-commits] LDRB_POST_IMM crash
> 
> Hi Silviu,
> Updated in attachment.
> -Stepan.
> 
> Silviu Baranga wrote:
> > Hi Stepan,
> >
> > The trailing CRs are around the diff headers.
> >
> > Could you move the ldrb CHECK line just above the memcpy call
> > and add a CHECK: main: line just above the main function?
> >
> > Cheers,
> > Silviu
> >
> >> -----Original Message-----
> >> From: Stepan Dyatkovskiy [mailto:stpworld at narod.ru]
> >> Sent: 08 October 2012 17:44
> >> To: Silviu Baranga
> >> Cc: llvm-commits
> >> Subject: Re: [llvm-commits] LDRB_POST_IMM crash
> >>
> >> Hi Silviu,
> >>
> >> Silviu Baranga wrote:
> >>
> >>> The test needs some CHECK lines or else it will not pass.
> >>> I suggest checking that the ldrb instruction was actually
> >>> generated.
> >> Sure. Patch fixed and reattached.
> >>
> >>> Some minor issues:
> >>> The patch has trailing CRs.
> >> Specially checked in hex editor. I found the only 0xA symbol at
> EOF...
> >>
> >> -Stepan.
> >
> >
> >