[llvm-commits] [ARM] Scheduler FixedFrame object vs byval formal parameters

Stepan Dyatkovskiy stpworld at narod.ru
Mon Oct 8 13:57:01 PDT 2012


Hi Akira,
I thought about that. It is question to TargetCallingConv.h owners, is 
it ok to add Argument* reference here? Alternatively we can modify 
LowerFormalArguments and pass vector with Argument pointers, which will 
has same size as InputArgs vector (not good imho).
Currently I stopped on way presented in patch...

-Stepan.

Akira Hatanaka wrote:
> Is it possible to use a pointer to the function argument (const Argument
> *) rather than the index?
>
> +    /// Index original Function's argument.
> +    unsigned OrigArgIndex;
>
> Just thought it might make the code in VarArgStyleRegisters simpler (no
> need to use std::advance).
>
> On Mon, Oct 8, 2012 at 11:15 AM, Stepan Dyatkovskiy <stpworld at narod.ru
> <mailto:stpworld at narod.ru>> wrote:
>
>     Sergei,
>
>     Sorry, I forgot to reattach testcase to the reworked patch. Please
>     find updated patch in attachment. I also attached testcase separately.
>
>     -Stepan.
>
>     Sergei Larin wrote:
>
>         Stepan,
>
>             Do you have an example that illustrates your issue? Sorry if
>         you have
>         already send it before... Thanks.
>
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>




More information about the llvm-commits mailing list