[llvm-commits] [PATCH] PowerPC Vector Floating-Point Rounding

[Adhemerval Zanella]

On 10/05/2012 04:13 PM, Hal Finkel wrote:
> ----- Original Message -----
> Two quick comments:
>
>  1. These instructions are not being explicitly marked as Legal in PPCISelLowering. I suppose this is the default, but we should explicitly mark them as legal for clarity.
>
>  2. This comments seems oddly worded:
>> +// Defines with the UIM field set to 0 to being used on floating-point
>> +// to integer (fp_to_sint/fp_to_uint) and on integer to floating-point
>> +// (sint_to_fp/uint_to_fp) conversions.
> How's this:
>
> // Defines with the UIM field set to 0 for floating-point
> // to integer (fp_to_sint/fp_to_uint) conversions and integer
> // to floating-point (sint_to_fp/uint_to_fp) conversions.
>
> Otherwise, LGTM.
>
> Thanks again,
> Hal

Thanks, I'll mark them explicitly legal on PPCISelLowering.cpp and change the comment.