[llvm-commits] [PATCH, PowerPC] Split Darwin and 64-bit SVR4 processing of LowerFormalArguments

[Chandler Carruth]

On Fri, Oct 5, 2012 at 2:25 PM, Hal Finkel <hfinkel at anl.gov> wrote:

>
>
> ----- Original Message -----
> > From: "William J. Schmidt" <wschmidt at linux.vnet.ibm.com>
> > To: llvm-commits at cs.uiuc.edu
> > Sent: Friday, October 5, 2012 4:20:53 PM
> > Subject: [llvm-commits] [PATCH, PowerPC] Split Darwin and 64-bit SVR4
> processing of LowerFormalArguments
> >
> > The attached patch is some TLC to split apart a function being used
> > by
> > both Darwin and 64-bit SVR4 ABIs.  There is no change in function.  I
> > have plans to make some nontrivial changes to the SVR4 ABI handling,
> > and
> > having the two ABIs separated will be better for all concerned.
> >
> > Tested with no new regressions.  Ok to commit?
>
> Alright (I assume the large block is copied from the Darwin version), LGTM.
>

Maybe I'm just confused, but why is it OK to copy/paste so much code from
Darwin? IS the code going away as you refactor it, or is there actually a
need to build an abstraction shared between the two?

(I may just not understand the end goal of the patch, in which case a
better explanation will fix matters...)


>
>  -Hal
>
> >
> > Thanks,
> > Bill
> > --
> > Bill Schmidt, Ph.D.
> > IBM Advance Toolchain for PowerLinux
> > IBM Linux Technology Center
> > wschmidt at us.ibm.com
> > wschmidt at linux.vnet.ibm.com
> >
> >
> >
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
> --
> Hal Finkel
> Postdoctoral Appointee
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121005/84a5b2d6/attachment.html>