[llvm-commits] Minor update to ReaderELF.cpp

Michael Spencer bigcheesegs at gmail.com
Wed Oct 3 13:14:25 PDT 2012


On Wed, Oct 3, 2012 at 12:31 PM, Sid Manning <sidneym at codeaurora.org> wrote:
> The following fixes a couple of issues with common symbols.
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation

>      // their size is zero.
>      if ((_symbol->getType() == llvm::ELF::STT_COMMON)
>          || _symbol->st_shndx == llvm::ELF::SHN_COMMON)
> -      return (uint64_t)0;
> +      return (uint64_t)_symbol->st_size;

Looks like this comment is out of date now.

Other than that it looks good to me.

- Michael Spencer



More information about the llvm-commits mailing list