[llvm-commits] [llvm] r164926 - /llvm/trunk/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp

Jakob Stoklund Olesen stoklund at 2pi.dk
Wed Oct 3 13:07:50 PDT 2012


On Oct 2, 2012, at 6:02 PM, Michael Liao <michael.liao at intel.com> wrote:

> On Tue, 2012-10-02 at 11:32 -0700, Jakob Stoklund Olesen wrote:
>> On Oct 2, 2012, at 11:25 AM, Michael Liao <michael.liao at intel.com> wrote:
>> 
>>> It seems to me a good idea. Attachment is my first draft to add this
>>> support in X86 backend. Thanks for your review.
>> 
>> Very nice.
>> 
>> I think it would be cleaner to use an X86Reg class that forces the HWEncoding to be set for all registers. See ARMReg in ARMRegisterInfo.td.
> 
> Here is the revised patch.

LGTM, assuming tests are passing, of course.

/jakob




More information about the llvm-commits mailing list