[llvm-commits] [PATCH]The ExecutionDepsFix pass does not propagate dependencies through implicit definitions

Silviu Baranga silbar01 at arm.com
Wed Oct 3 01:32:16 PDT 2012


Committed in r165102.

Thanks,
Silviu

> -----Original Message-----
> From: Jakob Stoklund Olesen [mailto:stoklund at 2pi.dk]
> Sent: 02 October 2012 17:07
> To: Silviu Baranga
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] [PATCH]The ExecutionDepsFix pass does not
> propagate dependencies through implicit definitions
> 
> 
> On Sep 24, 2012, at 6:49 AM, Silviu Baranga <silbar01 at arm.com> wrote:
> 
> > Hi,
> >
> > The attached patch fixes a problem with the ExecutionDependencyFix
> pass that
> > is causing some execution domain changes to not be performed.
> >
> > The visitSoftInstr method does not call setLiveReg for imp-def
> operands,
> > which
> > prevents domain collapsing when the dependency is caused by the imp-
> def
> > operand.
> > This is because the operand is not considered to be live.
> >
> > The attached patch also contains a simple regression test that can be
> used
> > to
> > replicate this behaviour.
> >
> > Please review.
> 
> LGTM.
> 
> 
> /jakob
> 
> 








More information about the llvm-commits mailing list