[llvm-commits] mips16 patch 19

Akira Hatanaka ahatanak at gmail.com
Thu Sep 27 11:30:36 PDT 2012


Patch looks fine to me. One minor problem:

* Perhaps this isn't important now, but shouldn't you use IILoad instead of
IIAlu for instruction itinerary here? Save and restore instructions have
IILoad.

+def LbRxRyOffMemX16: FEXT_RRI16_mem_ins<0b10011, "lb", mem16, IIAlu>,
MayLoad;


On Wed, Sep 26, 2012 at 2:34 PM, Reed Kotler <rkotler at mips.com> wrote:

>
>
> On 09/26/2012 02:05 PM, reed kotler wrote:
>
>> 1. Add load/store words from the stack
>> 2. As part of this, added assembly format FEXT_RI16_SP_explicit_ins and
>> moved other lines for FEXT_RI16 formats to be in the right place in the
>> code.
>> 3. Added mayLoad and mayStore assignements for the load/store
>> instructions added and for ones already there that did not have this
>> assignment.
>> 4. Another patch will deal with the problem of load/store byte/halfword
>> to the stack. This is a particular Mips16 problem.
>>
>>
>>
>>
>> ______________________________**_________________
>> llvm-commits mailing list
>> llvm-commits-**Tmj1lob9twqVc3sceRu5cw at public.**gmane.org<llvm-commits-Tmj1lob9twqVc3sceRu5cw at public.gmane.org>
>> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>>
>>  Forgot to say that I am looking for review before I commit this.
>
>
>
> ______________________________**_________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/**mailman/listinfo/llvm-commits<http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120927/7025e269/attachment.html>


More information about the llvm-commits mailing list