[llvm-commits] lld - WriterELF.cpp: Add case to SectionChunk

[Sid Manning]

On 09/26/12 11:48, Michael Spencer wrote:
> On Wed, Sep 26, 2012 at 8:51 AM, Sid Manning<sidneym at codeaurora.org>  wrote:
>> This is a small change:
>>
>>   * Add a case for DefinedAtom::typeConstant in SectionChunk so that read
>> only sections get created.
>>
>>   * Use the variable sectionName instead of ".bss" for typeZeroFill.
>>
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
>> The Linux Foundation
>
> Can you add a test case for this? With that it's good.

I could add a test case but there is a change to the reader that needs 
to happen in conjunction with this and that has not been committed yet.

Hemant wanted to move the bulk of ReaderELF.cpp into a header, after 
talking about it, moving the code into 
lld/include/ReaderWriter/ReaderELF.h instead of adding new ReaderELF.h 
to ELF seemed like a better idea, what do you think?

When I ran the test it showed me that the patch, as I submitted it, was 
missing the break statement in the newly added case.

>
> - Michael Spencer


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation