[llvm-commits] [PROPOSAL] Add --program-prefix support to build

Sebastian Pop spop at codeaurora.org
Tue Sep 25 14:18:22 PDT 2012


Committed as r164632 and r164633

Sebastian

On Tue, Sep 25, 2012 at 3:07 PM, Rick Foos <rfoos at codeaurora.org> wrote:
> Here are patches to llvm, and test-suite to add --program-prefix support.
>
> A few small changes are needed to pass the program prefix value and add the
> prefix to binary files that are installed.
>
> test-suite has one binary install step, and a similar change is done there.
>
> Polly has install steps, but it does not install binary files and doesn't
> need this change.
>
> -rick
>
>
>
>
> On 09/24/2012 05:54 PM, Rick Foos wrote:
>>
>> I'll pull config.guess from the patch. There are currently three different
>> versions of config.guess in the tree.
>>
>>
>> On 09/24/2012 03:13 PM, Jim Grosbach wrote:
>>>
>>> Updating config.guess should probably be a separate patch, as it's
>>> unrelated to the core change you're wanting. I gather the new version is
>>> still OK license-wise?
>>>
>> Yes, the GPL license exception is still in place.
>>
>> # As a special exception to the GNU General Public License, if you
>> # distribute this file as part of a program that contains a
>> # configuration script generated by Autoconf, you may include it under
>> # the same distribution terms that you use for the rest of that program.
>>
>>> No comment on the guts of the patch (I'm not familiar w/ how/why it
>>> failed before, so not really qualified to weigh in there).
>>>
>>> -Jim
>>>
>>> On Sep 24, 2012, at 1:03 PM, Sebastian Pop<spop at codeaurora.org>  wrote:
>>>
>>>> Hi,
>>>>
>>>> I would like to submit this patch again: the first time we had to revert
>>>> it
>>>> because some buildbots started failing.  Rick has then set up a
>>>> dragonegg bot to
>>>> test and fix the problems.  I think that we can try to push the patch
>>>> once more,
>>>> now that the problem is fixed.  If there are no objections, I will be
>>>> pushing
>>>> this and follow the build bots activity on IRC.
>>>>
>>>> Sebastian
>>>>
>>>> Rick Foos wrote:
>>>>>
>>>>> On 09/20/2012 10:52 PM, Rick Foos wrote:
>>>>>>
>>>>>> This patch adds --program-prefix support to the autoconf build.
>>>>>>
>>>>>> The cmake build isn't changed.
>>>>>>
>>>>>> makefile.rules now has program_prefix from configure. Some install
>>>>>> rules need it with Destdir.
>>>>>>
>>>>>> In configure.ac, A trap for the program_prefix = NONE before
>>>>>> AC_SUBST is needed. Configure ususally doesn't export
>>>>>> program-<prefix|suffix|transform>  variables, and the NONE default
>>>>>> value can escape w/o a trap.
>>>>>>
>>>>>> config.guess is updated to 2012-08-14. No platforms are removed.
>>>>>> Hexagon is added.
>>>>>>
>>>>>> --program-suffix wasn't included as it might interfere with the
>>>>>> EXEEXT variables, and goes beyond the scope of this patch.
>>>>>>
>>>>>> Thank you,
>>>>>> -rick
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> llvm-commits mailing list
>>>>>> llvm-commits at cs.uiuc.edu
>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>
>>>>>
>>
>
>
> --
> Rick Foos
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation



More information about the llvm-commits mailing list