[llvm-commits] [LLVMdev] Proposal: New IR instruction for casting between address spaces

Villmow, Micah Micah.Villmow at amd.com
Fri Sep 21 13:10:41 PDT 2012


Here is an updated patch which moves TargetData out of Target and into Support/VMCore so that there is no circular dependencies.

> -----Original Message-----
> From: Hal Finkel [mailto:hfinkel at anl.gov]
> Sent: Thursday, September 20, 2012 4:02 PM
> To: Eli Friedman
> Cc: Villmow, Micah; Mon Ping Wang; llvm-commits at cs.uiuc.edu;
> llvmdev at cs.uiuc.edu
> Subject: Re: [LLVMdev] Proposal: New IR instruction for casting between
> address spaces
> 
> On Thu, 20 Sep 2012 15:34:52 -0700
> Eli Friedman <eli.friedman at gmail.com> wrote:
> 
> > On Thu, Sep 20, 2012 at 3:30 PM, Villmow, Micah
> > <Micah.Villmow at amd.com> wrote:
> > > If I don't bring in TargetData, then there is no way for me to
> > > verify the address space size in the verifier or in the
> > > auto-upgrade mechanisms.
> >
> > And that's why I didn't like this approach in the first place.
> 
> I don't think that TargetData belongs in Target. TargetData represents
> target information that can be known without linking to the target
> descriptions, and thus needs to be available outside of Target.
> Furthermore, TargetData has no dependencies to the rest of Target (as
> far as I can tell). Let's move it into VMCore.
> 
>  -Hal
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bitcast_between_pointer_patch.txt
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120921/2307fc92/attachment.txt>


More information about the llvm-commits mailing list