[llvm-commits] [llvm] r164308 - in /llvm/trunk: include/llvm/Attributes.h lib/AsmParser/LLParser.cpp lib/CodeGen/MachineFunction.cpp lib/Target/CppBackend/CPPBackend.cpp lib/VMCore/Attributes.cpp

Bill Wendling isanbard at gmail.com
Fri Sep 21 08:09:16 PDT 2012


On Sep 20, 2012, at 2:08 PM, Benjamin Kramer <benny.kra at gmail.com> wrote:

> On 20.09.2012, at 18:27, Bill Wendling <isanbard at gmail.com> wrote:
> 
>>  bool operator != (const Attributes &Attrs) const {
>> -    return Bits != Attrs.Bits;
>> +    return !(this == Attrs);
> 
> Pointer to Attributes equals reference to Attributes? This compiles due to the conversion operator above, but I don't think it does what you intended it to do.
> 
Ah! Yes. Thanks for that. :)

-bw






More information about the llvm-commits mailing list