[llvm-commits] [Patch] Make sure isIdenticalTo takes into account the machine mem operands

[Hal Finkel]

On Thu, 20 Sep 2012 21:29:33 +0000
"Villmow, Micah" <Micah.Villmow at amd.com> wrote:

> In the case where we ran into problems, just checking the memory
> sizes was enough to detect that the two instructions were not
> identical. Outside of that, everything else about the instructions
> were the same.

Were the memory operands being encoded directly, or just used for alias
analysis?

 -Hal

> 
> > -----Original Message-----
> > From: Hal Finkel [mailto:hfinkel at anl.gov]
> > Sent: Thursday, September 20, 2012 2:18 PM
> > To: Villmow, Micah
> > Cc: llvm-commits at cs.uiuc.edu
> > Subject: Re: [llvm-commits] [Patch] Make sure isIdenticalTo takes
> > into account the machine mem operands
> > 
> > Micah,
> > 
> > Can you please explain the motivation for this? The memory operands
> > are only informative (not actually directly encoded), right? Is only
> > checking the sizes sufficient?
> > 
> >  -Hal
> > 
> > On Thu, 20 Sep 2012 15:19:53 +0000
> > "Villmow, Micah" <Micah.Villmow at amd.com> wrote:
> > 
> > > Ping!
> > >
> > > From: Villmow, Micah
> > > Sent: Tuesday, September 18, 2012 10:35 AM
> > > To: Villmow, Micah; llvm-commits at cs.uiuc.edu
> > > Subject: RE: [Patch] Make sure isIdenticalTo takes into account
> > > the machine mem operands
> > >
> > > Ping!
> > >
> > > From:
> > > llvm-commits-bounces at cs.uiuc.edu<mailto:llvm-commits-bounces at cs.uiuc.e
> > > du> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of
> > > du> Villmow,
> > > Micah
> > > Sent: Thursday, September 06, 2012 10:03 AM To:
> > > llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu> Subject:
> > > [llvm-commits] [Patch] Make sure isIdenticalTo takes into account
> > > the machine mem operands
> > >
> > > In some cases, MI->isIdenticalTo can return true when everything
> > > is equal but the mem operands. This makes sure that the machine
> > > mem operands are taken into account when checking if a
> > > MachineInstruction is equal to another.
> > >
> > > Thanks,
> > > Micah
> > 
> > 
> > 
> > --
> > Hal Finkel
> > Postdoctoral Appointee
> > Leadership Computing Facility
> > Argonne National Laboratory
> 
> 



-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory