[llvm-commits] [PATCH] Fix ARM MCJIT icache invalidation

Jim Grosbach grosbach at apple.com
Wed Sep 19 14:44:41 PDT 2012


Yep, that's an entirely reasonable fix. I agree, this is good to go in.

-Jim
On Sep 19, 2012, at 2:43 PM, Renato Golin <rengolin at systemcall.org> wrote:

> On 19 September 2012 15:50, Amara Emerson <amara.emerson at gmail.com> wrote:
>> I've attached a new patch that adds one call to getPointerToFunction()
>> just before invalidation. All ARM MCJIT tests now pass.
> 
> Clever! ;)
> 
> I can't see what this would have side effects beyond the ones you
> intend it to, and it's the same as the remote code is doing.
> 
> LGTM.
> 
> -- 
> cheers,
> --renato
> 
> http://systemcall.org/




More information about the llvm-commits mailing list