[llvm-commits] [llvm] r164173 - in /llvm/trunk: include/llvm/Transforms/Utils/IntegerDivision.h lib/Transforms/Utils/CMakeLists.txt lib/Transforms/Utils/IntegerDivision.cpp

[Owen Anderson]

On Sep 18, 2012, at 4:52 PM, Alex Rosenberg <alexr at leftfield.org> wrote:

> Let me pile on a few questions too:
> 
> * Why expand inline and not save code space by using glue like compiler-rt?

This is intended for use in non-static compilation scenarios where compiler-rt is not necessarily available.

> * When will this transform run relative to others? What interaction with other passes is presumed?

The intention is to run is as late as possible.  As you pointed out, this would make sense as a legalization, save for the technical limitation that legalization happens one basic block at a time.

> * Do you have more large expansions like this coming? Is there any common functionality that should be pulled out?

Not that I'm aware of.

> * Should we change compiler-rt to rely on this expansion?

Definitely not.  This isn't intended to replace any existing use case for compiler-rt, but to provide an alternative in scenarios where its use isn't appropriate.

--Owen