[llvm-commits] [llvm] r164173 - in /llvm/trunk: include/llvm/Transforms/Utils/IntegerDivision.h lib/Transforms/Utils/CMakeLists.txt lib/Transforms/Utils/IntegerDivision.cpp

[Eli Friedman]

On Tue, Sep 18, 2012 at 3:02 PM, Michael Ilseman <milseman at apple.com> wrote:
> Author: milseman
> Date: Tue Sep 18 17:02:40 2012
> New Revision: 164173
>
> URL: http://llvm.org/viewvc/llvm-project?rev=164173&view=rev
> Log:
> New utility for expanding integer division for targets that don't support it.
>
> Implementation derived from compiler-rt's implementation of signed and unsigned integer division.

This commit needs more explanation, given that you haven't added any
uses of expandDivision; how do you expect this to be used?

Why is this specialized for 32-bit division?

There are a lot of missed optimization opportunities here, e.g.
dividing by a constant; have you considered anything in this area?

-Eli