[llvm-commits] [PATCH] Set needed target on debuginfo tests

NAKAMURA Takumi geek4civic at gmail.com
Tue Sep 18 08:04:39 PDT 2012


Moved two test to X86, in r164129.
I believe it should satisfy you.

2012/9/18 Adhemerval Zanella <azanella at linux.vnet.ibm.com>:
> On 09/17/2012 09:28 PM, NAKAMURA Takumi wrote:
>> 2012/9/18 Adhemerval Zanella <azanella at linux.vnet.ibm.com>:
>>> Trivial patch to avoid make check-all errors when target 'x86-64-macosx' is
>>> not configured.
>>>  test/DebugInfo/2010-04-13-PubType.ll |    1 +
>>>  test/DebugInfo/linkage-name.ll       |    1 +
>>>  2 files changed, 2 insertions(+), 0 deletions(-)
>> Could they be move to test/DebugInfo/X86?
>>
>> +; REQUIRES: x86-64-macosx-registered-target
>>
>> FYI, I don't think llvm/test/lit.cfg would provide such a feature.
>> (or Did I miss other patchset?)
>> Then, they might be eventually suppressed.
>>
>> ...Takumi
>>
> I'd say the better approach might be moving these to the specific folder,
> however the REQUIRE feature seemed to work in my environment. I had only the
> powerpc backend built in this seems to avoid the test check error.

Undefined feature always suppresses the test, even with X86-enabled.
It were worse.
"*-registered-target" is provided only by clang/test/lit.cfg.

...Takumi



More information about the llvm-commits mailing list