[llvm-commits] [compiler-rt] r163923 - in /compiler-rt/trunk: SDKs/darwin/usr/include/stdio.h lib/profile/GCDAProfiling.c

[Hans Wennborg]

On Mon, Sep 17, 2012 at 2:13 PM, Hans Wennborg <hans at chromium.org> wrote:
>> /home/stomic/projects/llvm/projects/compiler-rt/lib/profile/GCDAProfiling.c:256:53:
>> error: format specifies type 'long long' but the argument has type
>> 'uint64_t'
>>       (aka 'unsigned long') [-Werror,-Wformat]
>>   COMPILE:   clang_linux/asan-x86_64/x86_64:
>> /home/stomic/projects/llvm/projects/compiler-rt/lib/asan/asan_interceptors.cc
>>
>>       fprintf(stderr, "old counter[%d]: %lld\n", j, old_ctrs[j]);
>>                                         ~~~~        ^~~~~~~~~~~
>>                                         %ld
>> 1 error generated.
>
> That looks more like a bug in Clang's printf format checker. I think
> using %lld for a uint64_t is perfectly reasonable.

But on the other hand, I guess we don't want to allow %lld with long
in general :(