[llvm-commits] [llvm] r163895 - /llvm/trunk/lib/Transforms/Scalar/SROA.cpp

[Matt Beaumont-Gay]

\yunoguy{CHANDLERC}{Y U NO SQUASH COMMITS?}

On Fri, Sep 14, 2012 at 3:30 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> Author: chandlerc
> Date: Fri Sep 14 05:30:42 2012
> New Revision: 163895
>
> URL: http://llvm.org/viewvc/llvm-project?rev=163895&view=rev
> Log:
> Be a bit more aggressive in bailing out of this routine. Spotted by
> inspection by Duncan during review. My suspicion is that we would still
> have returned 0 anyways in this case, but doing it sooner is better.
>
> Modified:
>     llvm/trunk/lib/Transforms/Scalar/SROA.cpp
>
> Modified: llvm/trunk/lib/Transforms/Scalar/SROA.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SROA.cpp?rev=163895&r1=163894&r2=163895&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Scalar/SROA.cpp (original)
> +++ llvm/trunk/lib/Transforms/Scalar/SROA.cpp Fri Sep 14 05:30:42 2012
> @@ -1336,7 +1336,7 @@
>
>    const StructLayout *SL = TD.getStructLayout(STy);
>    uint64_t StructOffset = Offset.getZExtValue();
> -  if (StructOffset > SL->getSizeInBytes())
> +  if (StructOffset >= SL->getSizeInBytes())
>      return 0;
>    unsigned Index = SL->getElementContainingOffset(StructOffset);
>    Offset -= APInt(Offset.getBitWidth(), SL->getElementOffset(Index));
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits