[llvm-commits] [PATCH] Fix PR11985

Michael Liao michael.liao at intel.com
Wed Sep 12 14:55:45 PDT 2012


On Wed, 2012-09-12 at 14:25 -0700, Evan Cheng wrote:
> LGTM.
> 
> BTW, for something fairly obvious like this patch you can just go ahead and commit. The community can review it after commit.

Committed in r163743.

Thanks for review
- Michael

> 
> Evan
> 
> On Sep 10, 2012, at 12:53 PM, Michael Liao <michael.liao at intel.com> wrote:
> 
> > Ping again. Thanks for review.
> > 
> > Yours
> > - Michael
> > 
> > On Wed, 2012-09-05 at 14:59 -0700, Michael Liao wrote:
> >> Ping.
> >> 
> >> Thanks for review
> >> - Michael
> >> 
> >> On Fri, 2012-08-31 at 10:38 -0700, Michael Liao wrote:
> >>> Hi
> >>> 
> >>> The attached patch addresses the issue found in PR11985. BlockAddress
> >>> doesn't support BA + offset form and has no way to propagate offset into
> >>> machine operand if target could support that. BlockAddress node is
> >>> revised to support extra offset (0 by default.) and
> >>> getTargetBlockAddress is added (similar to other symbol reference
> >>> nodes.) X86 backend is enhanced to prepare BlockAddress with non-0
> >>> offset. All other backends are slightly modified to use the new
> >>> interface.
> >>> 
> >>> Thanks for your review!
> >>> 
> >>> Yours
> >>> - Michael
> >>> 
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >> 
> >> 
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > 
> > <0001-Fix-PR11985.patch>_______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 





More information about the llvm-commits mailing list