[llvm-commits] [PATCH] Improve vmov domain conversion (followup)

[James Molloy]

Hi Jakob,

Sorry this has takena  few days to get back to you.

I've moved analyzePhysReg into MachineOperandIteratorBase, and renamed
"RegInfo" to "VirtRegInfo" so the physical and virtual query functions
are complementary.

I hope this is more satisfactory? :)

Cheers,

James

On Thu, 2012-09-06 at 20:48 +0100, Jakob Stoklund Olesen wrote:
> On Sep 6, 2012, at 11:51 AM, James Molloy <james.molloy at arm.com> wrote:
>
> > Hi Jakob,
> >
> > Do you mean MachineOperandIteratorBase::analyzeVirtReg()?
> >
> > I missed that (unsurprisingly I think; an iterator class seems an odd place to store such a function and Doxygen isn't clever about showing inherited members in subclasses).
>
> It lives there because it can analyze a whole bundle as well as a single instruction. The same would be useful for physregs.
>
> > I can relocate the code there instead and use a similar structure instead of enum bitmasks if you prefer?
>
> Yes, please.
>
> /jakob
>
>


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: improve-vmov-domain-conv.diff
Type: text/x-patch
Size: 16368 bytes
Desc: improve-vmov-domain-conv.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120911/39770bd6/attachment.bin>