[llvm-commits] [llvm] r163495 - /llvm/trunk/lib/CodeGen/StackColoring.cpp

[Jakob Stoklund Olesen]

On Sep 10, 2012, at 1:44 AM, Nadav Rotem <nrotem at apple.com> wrote:

> Author: nadav
> Date: Mon Sep 10 03:44:15 2012
> New Revision: 163495
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=163495&view=rev
> Log:
> Add an assertion that the frame index is indeed inside the declared lifetime region.

Hi Nadav,

The assertion is good, but I don't think CodeGen passes know how to preserve the invariant.

Many CodeGen passes are moving code around, including loads and stores. The lifetime markers oughtn't affect these optimizations, so either the optimizations must learn to update the lifetime markers, or the stack coloring pass must recognize when FI references have escaped the lifetime markers.

It also seems like the markers themselves could be moved around.

/jakob