[llvm-commits] [PATCH] Provide the capability of defining the CLANG_VENDOR with configure or cmake.

Ron Lieberman ronl at codeaurora.org
Sun Sep 9 15:42:35 PDT 2012


Attaching a revised patch which incorporates the suggested change on
spelling the option llvm-vendor.


---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Ron Lieberman
Sent: Sunday, September 09, 2012 7:33 AM
To: 'Duncan Sands'; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Provide the capability of defining the
CLANG_VENDOR with configure or cmake.

Hi Duncan,
Thanks for the suggestion.

I would be happy to change the option spelling to be
  Cmake:          -DLLVM_VENDOR=
  Configure:    --with-llvm-vendor=

FYI, the Clang source already contains the support for including the content
of CLANG_VENDOR when Clang is invoked with -v or --version, and when
defining the Macro __VERSION__ The modified patch will spell the option as
llvm_vendor, and will define CLANG_VENDOR which is currently only used
within the file 'tools/clang/lib/Basic/Version.cpp'
 
Thanks,
Ron Lieberman
---
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation


-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Duncan Sands
Sent: Sunday, September 09, 2012 12:43 AM
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] Provide the capability of defining the
CLANG_VENDOR with configure or cmake.

Hi Ron,

On 08/09/12 23:10, Ron Lieberman wrote:
> Provide the capability of defining the CLANG_VENDOR with configure or
cmake.

how about calling it LLVM_VENDOR instead?  After all, it may be useful for
all kinds of projects using LLVM, not just clang.  And I don't much like
putting clang specific stuff into LLVM if it can be avoided - seems like a
layering violation.

Ciao, Duncan.

>
> Default for the new configure options:
>
>    --with-clang-vendor defaults to null.
>
> The vendor name is configured using the following option
>
>    --with-clang-vendor="INTLWICKET " \
>
> Examples:
>
> $ clang -v
>
> INTLWICKET clang version 3.2  (based on LLVM 3.2svn)
>
> Target: x86_64-unknown-linux-gnu
>
> Thread model: posix
>
> The __VERSION__ macro becomes:
>
> define __VERSION__ "4.2.1 Compatible INTLWICKET Clang 3.2 "
>
> Testing:
>
> cmake
>
> cmake -DCLANG_VENDOR=
>
> cmake -DCLANG_VENDOR="INTLWICKET "
>
> configure
>
> configure --with-clang-vendor=
>
> configure --with-clang-vendor="INTLWICKET "
>
> Ron Lieberman
>
> ---
>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
> hosted by The Linux Foundation
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Provide-the-capability-of-defining-CLANG_VENDOR.patch
Type: application/octet-stream
Size: 4750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120909/e0e9a595/attachment.obj>


More information about the llvm-commits mailing list