[llvm-commits] [PATCH] removing a newline when printing a Global Variable

Duncan Sands baldrick at free.fr
Fri Sep 7 03:33:27 PDT 2012


Hi Saša, welcome to LLVM!

On 07/09/12 10:25, Saša Tomić wrote:
> And of course, the first patch was wrong -- it included git color codes. :(
> Here's the correct one.

Thanks for the patch, but: why is it correct - what is the issue you are fixing?
Can you give an example?  Also, please add a testcase.

Best wishes, Duncan.

>
> On 09/07/2012 10:23 AM, Saša Tomić wrote:
>> Hi to all,
>>
>> this is my first patch for LLVM. I'm not really aware of all the rules and the
>> norms that should be followed here.
>> I did read the text at http://llvm.org/docs/DeveloperPolicy.html
>>
>> This is just a minor fix, dropping a newline when a global variable is printed.
>> So here is the patch (in the attachment).
>>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list