[llvm-commits] [PATCH] Improve vmov domain conversion (followup)

Jakob Stoklund Olesen stoklund at 2pi.dk
Thu Sep 6 12:48:11 PDT 2012


On Sep 6, 2012, at 11:51 AM, James Molloy <james.molloy at arm.com> wrote:

> Hi Jakob,
> 
> Do you mean MachineOperandIteratorBase::analyzeVirtReg()?
> 
> I missed that (unsurprisingly I think; an iterator class seems an odd place to store such a function and Doxygen isn't clever about showing inherited members in subclasses).

It lives there because it can analyze a whole bundle as well as a single instruction. The same would be useful for physregs.

> I can relocate the code there instead and use a similar structure instead of enum bitmasks if you prefer?

Yes, please.

/jakob



More information about the llvm-commits mailing list