[llvm-commits] patch: produce more relocation value strings on x86-64 elf

[Nick Lewycky]

On 31 August 2012 22:10, Michael Spencer <bigcheesegs at gmail.com> wrote:

> On Fri, Aug 31, 2012 at 6:44 PM, Nick Lewycky <nlewycky at google.com> wrote:
> > The attached patch updates libObject's code for producing a string
> > representing a relocation. This lets us emit "Unknown" far less often.
> The
> > test is a .o assembled from this .s:
> >
> > .text
> >   func:
> >     movb $somedata-4, %al
> >     movw $somedata-4, %ax
> >     movl $somedata-4, %eax
> >     movq $somedata-4, %rax
> >     movabsl somedata-4, %eax
> >     movl %eax, somedata(%rip)
> >
> >     movl $somedata, %ebx
> >
> >     movl $somedata+4, %ecx
> >
> > .data
> >   somedata:
> >     .long 0x0
> >
> > Please review!
> >
> > Nick
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
> Is fmt.flush() really needed? Other than that LGTM.
>

Sadly it is. Thanks for the review!

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120905/b4f5abed/attachment.html>