[llvm-commits] [PATCH] Review request: Allow assembly macro parameters and arguments delimited by spaces

Zhang, Andy andy.zhang at intel.com
Wed Sep 5 11:44:17 PDT 2012


On August 30, 2012 4:26 PM, Rafael EspĂ­ndola wrote:

> Sorry, I completely forgot to reply to this email. I was extracting
> bits from the patch because it is still very large, which make it a bit
> hard to read. I also think it is missing some tests. Can you please try
> to split it in
> 
> * Comments and string fixes that already make sense on the current
> code.
> * Macro nesting fixes.
> * Support for default argument values
> * Changing the lexing to support white spaces.
> 
> at least the last 3 should have tests in them.
> 
> Cheers,
> Rafael

I will split them as you suggested.

This patch changes the error message for .endr to not be specific to matching a .rept, since it can occur for other directives too (like .irpc).

- Andy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: endr-msg.diff
Type: application/octet-stream
Size: 895 bytes
Desc: endr-msg.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120905/dd38220a/attachment.obj>


More information about the llvm-commits mailing list