[llvm-commits] [PATCH] Remove redundant register copies when inserting to Q registers on ARM

James Molloy James.Molloy at arm.com
Wed Sep 5 11:40:19 PDT 2012


Hi Jakob,

I actually ummed and urred about that for a while before writing what I did. Glad to know which version is preferred.

I'll change that tomorrow morning, then am I good to commit?

Thanks very much for reviewing this by the way.

James
________________________________________
From: Jakob Stoklund Olesen [stoklund at 2pi.dk]
Sent: 05 September 2012 19:39
To: James Molloy
Cc: llvm-commits at cs.uiuc.edu; anton at korobeynikov.info
Subject: Re: [llvm-commits] [PATCH] Remove redundant register copies when inserting to Q registers on ARM

On Sep 5, 2012, at 1:03 AM, James Molloy <james.molloy at arm.com> wrote:

> Hi Jakob, Anton,
>
> Thanks for the comments; I've integrated them and attach a new patch
> that should address them.

Looks good, except:

+        DLane = QLane & 7;                                   // QLane % 8
+        DSubReg  = (QLane >> 3) ? ARM::dsub_1 : ARM::dsub_0; // QLane / 8

If '% 8' and '/ 8' best express what you're doing, just write that.

Thanks,
/jakob




-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.





More information about the llvm-commits mailing list