[llvm-commits] [PATCH 1/5] Fix arithmetic promotion rule in ELF.h

Will Schmidt will_schmidt at vnet.ibm.com
Wed Sep 5 10:13:24 PDT 2012


On Wed, 2012-09-05 at 13:00 -0300, Adhemerval Zanella wrote:
> Fix for some arithmetic additions being handled as signed where it should
> not. Also add the PPC64 triple definitions.

The 0 to 0UL changes look reasonable to me.   Did you identify an
existing testcase that fails/works with the signed change?   I didn't
notice a difference out of 'gmake check-all' with/without this patch
applied. 

May wish to break out the PPC64 triple change, I think it's mostly
unrelated to the 0UL bits.

Thanks, 
-Will




> 
> Please review.
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list