[llvm-commits] PATCH: Tablegen - Add OperandWithDefaultOps for encoding target flags as immediates

[Jakob Stoklund Olesen]

On Sep 4, 2012, at 11:59 AM, Tom Stellard <tom at stellard.net> wrote:

> On Tue, Sep 04, 2012 at 10:37:19AM -0700, Jakob Stoklund Olesen wrote:
>> 
>> On Aug 31, 2012, at 9:45 AM, Tom Stellard <tom at stellard.net> wrote:
>> 
>>> Hi,
>>> 
>>> This patch adds the OperandWithDefaultOps operand type to tablegen.
>>> This new class serves as a base class for PredicateOperand and
>>> OptionalDefOperand, but it could also be used for encoding target flags
>>> as immediate operands, which is necessary now the MachineOperand flags
>>> are gone.
>> 
>> Hi Tom,
>> 
>> This is a nice generalization, thanks for working on it.
>> 
>> Please verify that the generated ARMGen*.inc files are not changed by this patch.
>> 
> 
> Hi Jakob,
> 
> The only change is that the OperandMatchTable in ARMGenAsmMatcher.inc
> has been reordered (see attached diff).  I sorted the OperandMatchTable for both
> the old and the new files to verify all the data was the same, so the
> only difference is the order of the entries.

Thanks, go ahead and commit.

/jakob