[llvm-commits] "[PATCH] AddressSanitizer tests for initialization order and blacklist"

[Reid Watson]

Sorry for the delay!

I'd rather not separate the blacklists.  Instead, I'd propose adding
better granularity to the prefixes controlling blacklisting.  I've
attached updated versions of the path which add:

# Disable redzones and initialization order
global: [wildcard]
# Disables initialization order but not redzones
global-init: [wildcard]

I can add a global-redzones prefix (disable redzones, but not
initialization), but that'll require a bit of refactoring in the
instrumentation pass.  Let me know if the general approach is
acceptable / if there's any particular feedback on the patch!

Thanks for the review,
Reid

On Mon, Sep 3, 2012 at 7:20 AM, Alexey Samsonov <samsonov at google.com> wrote:
>
>
> On Wed, Aug 29, 2012 at 4:10 PM, Kostya Serebryany <kcc at google.com> wrote:
>>
>> First question: do we want to use the same blacklist flag for both regular
>> asan functionality and the global init checker?
>> Suppose you have a few globals in foo.cc that you want to ignore.
>> Then you add src:foo.cc to the blacklist file and suddenly you disable all
>> of asan instrumentation for this file.
>> Maybe we better add a new flag, -asan-global-init-blacklist ?
>
>
> Reid, WDYT?
>
>>
>>
>>
>> --kcc
>>
>> On Wed, Aug 29, 2012 at 12:49 AM, Reid Watson <reidw at google.com> wrote:
>>>
>>> Hello -- two patches here,
>>>
>>> The first adds lit_tests for the ASan blacklist and initialization
>>> order checking system.
>>>
>>> The second is a one line change to the ASan instrumentation pass which
>>> probably should have been included in the previous blacklist patch.
>>> The tests will fail if this patch is not applied.
>>>
>>> All the best,
>>> Reid
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
>
> --
> Alexey Samsonov, MSK
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asan-tests.patch
Type: application/octet-stream
Size: 8136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120904/1d0de562/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: blacklist-enable.patch
Type: application/octet-stream
Size: 2661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120904/1d0de562/attachment-0001.obj>