[llvm-commits] [llvm] r162963 - in /llvm/trunk: lib/Target/X86/X86InstrSSE.td test/MC/X86/x86-64.s

[Bill Wendling]

On Aug 31, 2012, at 10:22 AM, Jim Grosbach <grosbach at apple.com> wrote:

>>> Modified: llvm/trunk/test/MC/X86/x86-64.s
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/x86-64.s?rev=162963&r1=162962&r2=162963&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/test/MC/X86/x86-64.s (original)
>>> +++ llvm/trunk/test/MC/X86/x86-64.s Thu Aug 30 19:30:30 2012
>>> @@ -1164,6 +1164,10 @@
>>> // CHECK: encoding: [0x66,0x48,0x0f,0x6e,0xc7]
>>> 	movd %rdi,%xmm0
>>> 
>>> +// CHECK: movd  %xmm0, %rax
>>> +// CHECK: encoding: [0x66,0x48,0x0f,0x7e,0xc0]
>>> +        movd  %xmm0, %rax
>>> +
>> Maybe I'm missing something...but should you be checking for 'vmovd' instead of 'movd'?
>> 
> 
> We're checking the now-correct encoding of an instruction we were previously mis-assembling due to the missing 'v'.
> 
Oh! I see. So the assembler was finding the 'vmovd' instead of the 'movd' and then generating the bad encoding...got it. :) Thanks!

-bw