[llvm-commits] [RFC/PATCH] introduce 'UseSSEx' predicates

[Michael Liao]

On Wed, 2012-08-29 at 16:21 -0700, Eli Friedman wrote:
> On Tue, Aug 28, 2012 at 11:25 AM, Michael Liao <michael.liao at intel.com> wrote:
> > Ping again for comment on this proposal. - Michael
> >
> > On Sun, 2012-08-26 at 02:57 -0700, Michael Liao wrote:
> >> On Fri, 2012-08-24 at 19:23 -0700, Eli Friedman wrote:
> >> > On Fri, Aug 24, 2012 at 6:55 PM, Michael Liao <michael.liao at intel.com> wrote:
> >> > > On Fri, 2012-08-24 at 18:14 -0700, Eli Friedman wrote:
> >> > >> On Wed, Aug 22, 2012 at 10:27 AM, Michael Liao <michael.liao at intel.com> wrote:
> >> > >> > Hi
> >> > >> >
> >>
> >> Regard to the failure of MCJIT with this patch, finally I find the root
> >> cause. Target constant rematerialization in X86 fast-isel doesn't handle
> >> large code model correctly and create a PC-rel addressing which crashes
> >> when the displacement is out of 32-bit immediate range. I added a simple
> >> fix similar to large code model is handled in X86 fast-isel in
> >> elsewhere.
> >>
> >> The patch is revised and attached here. Not sure it's ok to commit.
> 
> The fast-isel changes look fine; please commit as a separate patch
> with its own testcase.
> 
> The other changes also look reasonable, but I would prefer if someone
> else familiar with AVX could take a look as well.
> 
> Please file a bug on the fast-isel floating-point constant issue once
> you commit this.

The bug in fast-isel is filed as PR13727,
http://llvm.org/bugs/show_bug.cgi?id=13727. I leave comments here that
the bug is fixed but may need better support of large code model in
fast-isel.

Thanks
- Michael

> 
> -Eli