[llvm-commits] [PATCH] Preserve branch weight metadata when creating switches in SimplifyCFG

Alastair Murray alastairmurray42 at gmail.com
Wed Aug 29 15:51:46 PDT 2012


Hi Andrew, Michael,

On 29/08/12 23:03, Andrew Trick wrote:
> Michael Ilseman was independently working on a patch based on a design that we had discussed informally. I just reviewed his patch offline and committed r162868. He has verified the patch with set of tests that he'll be posting. I attempted to explain the weight balancing formula in the checkin comments. Michael did not fix all places where we convert to switches, so there is still work to do, but I hope this helps you.

At a quick glance it seems to work quite differently from my own 
version.  I'll have a more thorough read.

> Michael is not actively working on it, so if you find any more cases that need to be implemented that would be much appreciated. Also feel free to improve or factor the code however is convenient for you.

I will see how it handles my own test cases and proceed from there.

Regards,
Alastair



More information about the llvm-commits mailing list