[llvm-commits] "[PATCH] AddressSanitizer tests for initialization order and blacklist"

[Alexey Samsonov]

On Wed, Aug 29, 2012 at 6:02 PM, Kostya Serebryany <kcc at google.com> wrote:

>
>
> On Wed, Aug 29, 2012 at 5:31 PM, Alexey Samsonov <samsonov at google.com>wrote:
>
>>
>> On Wed, Aug 29, 2012 at 4:10 PM, Kostya Serebryany <kcc at google.com>wrote:
>>
>>> First question: do we want to use the same blacklist flag for both
>>> regular asan functionality and the global init checker?
>>> Suppose you have a few globals in foo.cc that you want to ignore.
>>> Then you add src:foo.cc to the blacklist file and suddenly you disable
>>> all of asan instrumentation for this file.
>>> Maybe we better add a new flag, -asan-global-init-blacklist ?
>>>
>>
>> Hm, why can't we add several "global:*badGlobal*" lines to the blacklist
>> file?
>> (I assume it is supported from reading the test cases).
>>
> What if we have an auto-generated file with tons of globals?
>

Then it unlikely contains anything else and it's fine to disable
instrumentation for it :)
I just don't think we need that precise tuning to introduce another flag,
but ymmv.



>
>>
>>
>>>
>>>
>>> --kcc
>>>
>>> On Wed, Aug 29, 2012 at 12:49 AM, Reid Watson <reidw at google.com> wrote:
>>>
>>>> Hello -- two patches here,
>>>>
>>>> The first adds lit_tests for the ASan blacklist and initialization
>>>> order checking system.
>>>>
>>>> The second is a one line change to the ASan instrumentation pass which
>>>> probably should have been included in the previous blacklist patch.
>>>> The tests will fail if this patch is not applied.
>>>>
>>>> All the best,
>>>> Reid
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>>
>> --
>> Alexey Samsonov, MSK
>>
>>
>


-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120829/c0c1418a/attachment.html>