[llvm-commits] [PATCH] Thumb2 cond/uncond branch fixup for ELF

[Logan Chien]

Hi Tim,

  Thanks for your reply.  I have checked the code again.  You are right.
fixup_t2_condbranch and fixup_t2_uncondbranch is always PC-relative.
Thus, I'm removing the duplicated code in the new patch set.  Please
have a look.  Thanks.

Sincerely,
Logan


On Wed, Aug 29, 2012 at 5:59 PM, Tim Northover <t.p.northover at gmail.com>wrote:

> Hi Logan,
>
> >   It seems that ARMELFObjectWriter is not translating fixup_t2_condbranch
> > and fixup_t2_uncondbranch into R_ARM_THM_JUMP24.  As a result, "llc"
> > can not compile following code correctly with integrated assembler.  I
> hope
> > these patches can fix this issue.  Please review.  Thanks!
>
> The results look good to me, but I'm a little confused about the
> duplication for both IsPCRel and !IsPCRel. Shouldn't these fixups
> always be PC-relative?
>
> Tim.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120829/e5af9e54/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-ARM-ELF-support-to-llvm-objdump.patch
Type: application/octet-stream
Size: 8570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120829/e5af9e54/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-thumb2-fixup-kind-in-the-integrated-as.patch
Type: application/octet-stream
Size: 2192 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120829/e5af9e54/attachment-0001.obj>