[llvm-commits] [Please review][PATCH] Implement the block_iterator of Region based on df_iterator.

[Hongbin Zheng]

On Mon, Aug 27, 2012 at 2:51 PM, Tobias Grosser <tobias at grosser.es> wrote:
> On 08/27/2012 05:06 AM, Hongbin Zheng wrote:
>>
>> Hi,
>>
>> I attached a patch that make the function "Region::print" use the
>> newly introduced block_iterator instead of the block_node_iterator.
>> With this patch, the block_iterator is actually tested by the regression
>> tests.
>
>
> Does this mean the block_node_iterator is now untested? If that is the case
> we should either remove it add tests that ensure that it is still tested.
It is removed now, please have a look at this patch.
>
> Otherwise, adding printing and testing for the block_iterator itself sounds
> like a good addition. Also switching the default to the block_iterator seems
> fine.
>
> Tobi

best regards
ether
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-the-the-block_node_iterator-of-Region-replace.patch
Type: text/x-diff
Size: 4399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120827/c3d89156/attachment.patch>