[llvm-commits] [llvm] r162655 - in /llvm/trunk/test/CodeGen/X86: fma.ll fma3-intrinsics.ll fma4-intrinsics-x86_64.ll fma_patterns.ll

Anitha Boyapati anitha.boyapati at gmail.com
Mon Aug 27 03:25:53 PDT 2012


On 27 August 2012 15:11, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Fixed in r162664. You could reproduce the failure to add to it locally;
>
> -mtriple=i686-unknown-unknown
> -mtriple=x86_64-mingw32
>

I can repro it now.  Thanks for fixing it.

-Anitha

2012/8/27 Anitha Boyapati <anitha.boyapati at gmail.com>:

> >
> >
> > On 27 August 2012 12:39, Chandler Carruth <chandlerc at google.com> wrote:
> >>
> >> FYI, it seems like a build bot failed:
> >>
> >> http://bb.pgr.jp/builders/cmake-clang-i686-mingw32/builds/15
> >
> >
> > Strange. The test fma_patterns.ll passes for me with rev 162655.
> >
> > build/test> clang -v
> > clang version 3.2 (trunk 162661) (llvm/trunk 162654:162655M)
> > Target: x86_64-unknown-linux-gnu
> > Thread model: posix
> > build/test> llvm-lit CodeGen/X86/fma_patterns.ll
> > -- Testing: 1 tests, 1 threads --
> > PASS: LLVM :: CodeGen/X86/fma_patterns.ll (1 of 1)
> > Testing Time: 0.08s
> >   Expected Passes    : 1
> >
> > Moreover, for that particular function "def _test_x86_fnmadd_ss" (
> reported
> > as failed), I could see that the generated assembly is same as what is
> > expected in fma_patterns.ll
> >
> >>>>>>>>>>
> > build/test> llc -mcpu=bdver2 -mattr=-fma4 -fp-contract=fast
> > test_x86_fnmadd.ll
> > build/test> more test_x86_fnmadd.s
> >         .file   "test_x86_fnmadd.ll"
> >         .text
> >         .globl  test_x86_fnmadd_ss
> >         .align  16, 0x90
> >         .type   test_x86_fnmadd_ss, at function
> > test_x86_fnmadd_ss:                     # @test_x86_fnmadd_ss
> >         .cfi_startproc
> > # BB#0:
> >         vfnmadd213ss    %xmm2, %xmm0, %xmm1
> >         vmovaps %xmm1, %xmm0
> >         ret
> > .Ltmp0:
> >         .size   test_x86_fnmadd_ss, .Ltmp0-test_x86_fnmadd_ss
> >         .cfi_endproc
> > <<<<<<
> >
> > Looks like given report has memory form of fma. Am I missing something
> here?
> > Can mingw32 make a difference?
> >
> > -Anitha
> >>
> >>
> >>
> >> On Sun, Aug 26, 2012 at 11:59 PM, Anitha Boyapati
> >> <anitha.boyapati at gmail.com> wrote:
> >>>
> >>> Author: anithab
> >>> Date: Mon Aug 27 01:59:01 2012
> >>> New Revision: 162655
> >>>
> >>> URL: http://llvm.org/viewvc/llvm-project?rev=162655&view=rev
> >>> Log:
> >>>
> >>> FMA3 tests on bdver2 target for changes made in rev 162012. Also made
> >>> corresponding changes to existing tests for darwin triple to ensure
> that
> >>> same pattern is tested for bdver2 target.
> >>>
> >>>
> >>> Modified:
> >>>     llvm/trunk/test/CodeGen/X86/fma.ll
> >>>     llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll
> >>>     llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll
> >>>     llvm/trunk/test/CodeGen/X86/fma_patterns.ll
> >>>
> >>> Modified: llvm/trunk/test/CodeGen/X86/fma.ll
> >>> URL:
> >>>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma.ll?rev=162655&r1=162654&r2=162655&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- llvm/trunk/test/CodeGen/X86/fma.ll (original)
> >>> +++ llvm/trunk/test/CodeGen/X86/fma.ll Mon Aug 27 01:59:01 2012
> >>> @@ -1,11 +1,13 @@
> >>> -; RUN: llc < %s -mtriple=i386-apple-darwin10  -mattr=+fma  | FileCheck
> >>> %s --check-prefix=CHECK-FMA-INST
> >>> -; RUN: llc < %s -mtriple=i386-apple-darwin10               | FileCheck
> >>> %s --check-prefix=CHECK-FMA-CALL
> >>> -; RUN: llc < %s -mtriple=x86_64-apple-darwin10 -mattr=+fma | FileCheck
> >>> %s --check-prefix=CHECK-FMA-INST
> >>> -; RUN: llc < %s -mtriple=x86_64-apple-darwin10             | FileCheck
> >>> %s --check-prefix=CHECK-FMA-CALL
> >>> +; RUN: llc < %s -mtriple=i386-apple-darwin10  -mattr=+fma,-fma4  |
> >>> FileCheck %s --check-prefix=CHECK-FMA-INST
> >>> +; RUN: llc < %s -mtriple=i386-apple-darwin10  -mattr=-fma,-fma4  |
> >>> FileCheck %s --check-prefix=CHECK-FMA-CALL
> >>> +; RUN: llc < %s -mtriple=x86_64-apple-darwin10 -mattr=+fma,-fma4 |
> >>> FileCheck %s --check-prefix=CHECK-FMA-INST
> >>> +; RUN: llc < %s -mtriple=x86_64-apple-darwin10  -mattr=-fma,-fma4 |
> >>> FileCheck %s --check-prefix=CHECK-FMA-CALL
> >>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma4  | FileCheck %s
> >>> --check-prefix=CHECK-FMA-INST
> >>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma,-fma4 | FileCheck %s
> >>> --check-prefix=CHECK-FMA-CALL
> >>>
> >>>  ; CHECK: test_f32
> >>>  ; CHECK-FMA-INST: vfmadd213ss
> >>> -; CHECK-FMA-CALL: _fmaf
> >>> +; CHECK-FMA-CALL: fmaf
> >>>
> >>>  define float @test_f32(float %a, float %b, float %c) nounwind readnone
> >>> ssp {
> >>>  entry:
> >>> @@ -15,7 +17,7 @@
> >>>
> >>>  ; CHECK: test_f64
> >>>  ; CHECK-FMA-INST: vfmadd213sd
> >>> -; CHECK-FMA-CALL: _fma
> >>> +; CHECK-FMA-CALL: fma
> >>>
> >>>  define double @test_f64(double %a, double %b, double %c) nounwind
> >>> readnone ssp {
> >>>  entry:
> >>> @@ -24,7 +26,7 @@
> >>>  }
> >>>
> >>>  ; CHECK: test_f80
> >>> -; CHECK: _fmal
> >>> +; CHECK: fmal
> >>>
> >>>  define x86_fp80 @test_f80(x86_fp80 %a, x86_fp80 %b, x86_fp80 %c)
> >>> nounwind readnone ssp {
> >>>  entry:
> >>>
> >>> Modified: llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll
> >>> URL:
> >>>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll?rev=162655&r1=162654&r2=162655&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll (original)
> >>> +++ llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll Mon Aug 27 01:59:01
> >>> 2012
> >>> @@ -1,5 +1,6 @@
> >>>  ; RUN: llc < %s -mtriple=x86_64-pc-win32 -mcpu=core-avx2 | FileCheck
> %s
> >>>  ; RUN: llc < %s -mtriple=x86_64-pc-win32 -mattr=+fma,+fma4 | FileCheck
> >>> %s
> >>> +; RUN: llc < %s -mcpu=bdver2 -mtriple=x86_64-pc-win32 -mattr=-fma4 |
> >>> FileCheck %s
> >>>
> >>>  define <4 x float> @test_x86_fmadd_ss(<4 x float> %a0, <4 x float>
> %a1,
> >>> <4 x float> %a2) {
> >>>    ; CHECK: fmadd213ss %xmm
> >>>
> >>> Modified: llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll
> >>> URL:
> >>>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll?rev=162655&r1=162654&r2=162655&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll (original)
> >>> +++ llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll Mon Aug 27
> >>> 01:59:01 2012
> >>> @@ -1,4 +1,5 @@
> >>>  ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -march=x86-64
> >>> -mattr=+avx,+fma4 | FileCheck %s
> >>> +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=bdver2
> >>> -mattr=+avx,-fma | FileCheck %s
> >>>
> >>>  ; VFMADD
> >>>  define < 4 x float > @test_x86_fma_vfmadd_ss(< 4 x float > %a0, < 4 x
> >>> float > %a1, < 4 x float > %a2) {
> >>>
> >>> Modified: llvm/trunk/test/CodeGen/X86/fma_patterns.ll
> >>> URL:
> >>>
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma_patterns.ll?rev=162655&r1=162654&r2=162655&view=diff
> >>>
> >>>
> ==============================================================================
> >>> --- llvm/trunk/test/CodeGen/X86/fma_patterns.ll (original)
> >>> +++ llvm/trunk/test/CodeGen/X86/fma_patterns.ll Mon Aug 27 01:59:01
> 2012
> >>> @@ -1,4 +1,5 @@
> >>>  ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=core-avx2
> >>> -mattr=avx2,+fma -fp-contract=fast | FileCheck %s
> >>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma4 -fp-contract=fast |
> FileCheck
> >>> %s
> >>>
> >>>  ; CHECK: test_x86_fmadd_ps
> >>>  ; CHECK: vfmadd213ps     %xmm2, %xmm0, %xmm1
> >>>
> >>>
> >>> _______________________________________________
> >>> llvm-commits mailing list
> >>> llvm-commits at cs.uiuc.edu
> >>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >>
> >>
> >
> >
> >
> > --
> >  Anitha
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>



-- 
* Anitha*
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120827/c3b01cf3/attachment.html>


More information about the llvm-commits mailing list