[llvm-commits] [PATCH] Extend sanitizer blacklist functionality

Kostya Serebryany kcc at google.com
Thu Aug 23 03:41:47 PDT 2012


Looks good in general, I'll commit later unless someone objects.

Just curious, what is your use case?
We sometimes use the blacklists for asan/msan/tsan during initial
deployment in a particular source base,
but long term we always try to fix the code (and mark the tricky code with
attributes) and get rid of the blacklist.

Thanks!

--kcc


On Wed, Aug 22, 2012 at 11:00 PM, Reid Watson <reidw at google.com> wrote:

> Also, for ease of review, here's a version with no renaming of files
> involved.  It preserves the FunctionBlackList name, though that should
> probably be changed if this is committed.
>
> On Wed, Aug 22, 2012 at 11:08 AM, Reid Watson <reidw at google.com> wrote:
> > Hi all,
> >
> > First off, sincere thanks to reviewers(kcc especially) for helping
> > with the initial initialization order patch.
> >
> > I'm now looking to expand the blacklisting functionality of
> > AddressSanitizer to include the ability to blacklist global variables.
> >  This is currently handled in FunctionBlackList.h, which is renamed to
> > BlackList.h to reflect the fact that it can store more than functions.
> >
> > I've attached the patch and uploaded it to
> > Rietveld(http://codereview.appspot.com/6473048/).  Review is
> > appreciated as always.
> >
> > All the best,
> > Reid
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120823/c7c864ab/attachment.html>


More information about the llvm-commits mailing list